Handle preference alerts from the PlatformsListView#470
Merged
MattKiazyk merged 1 commit intoXcodesOrg:mainfrom Jan 19, 2024
Merged
Handle preference alerts from the PlatformsListView#470MattKiazyk merged 1 commit intoXcodesOrg:mainfrom
MattKiazyk merged 1 commit intoXcodesOrg:mainfrom
Conversation
Contributor
|
Thanks @chickdan - short story is originally I had it in Settings, but forgot to move the alert with it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The expected alert when choosing to delete a platform was not appearing. If I opened the
PreferencesViewand moved it off to the side I can see the alert appear over it when clicking the delete button. After adding this change I was able to see the alert in thePlatformsListView.Before:
After: