Add ability to cancel runtime downloads#453
Merged
MattKiazyk merged 3 commits intomainfrom Dec 3, 2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When downloading runtimes, they sometimes can take a long time. This adds the ability to cancel a runtime as it's downloading.
This keeps the continuation of moving away from Combine into Swift Concurrency by using
AsyncThrowingStream. Which the progress streams back as it downloads. This is a new one for me and things seem to be working. I could only get it to work by wrapping the process code around aTaskINSIDE thereturn AsyncThrowingStream<Progress, Error> { continuation in.I did add a TODO around progress warning. I believe
ProgressWrappercombines the latest which stops me from just passing a new Progress back