Activity Indicator on Install Pressed#437
Merged
MattKiazyk merged 4 commits intoXcodesOrg:mainfrom Dec 13, 2023
Merged
Conversation
MattKiazyk
requested changes
Nov 22, 2023
Contributor
MattKiazyk
left a comment
MattKiazyk
left a comment
There was a problem hiding this comment.
Thanks @chickdan !
Can we switch it to use ProgressButton that we already have?
Xcodes/Backend/XcodeCommands.swift
Outdated
|
|
||
| var body: some View { | ||
| Button(action: install) { |
Contributor
There was a problem hiding this comment.
Can we reuse ProgressButton that we have already (2FA/SMS windows)
MattKiazyk
requested changes
Dec 1, 2023
Xcodes/Backend/XcodeCommands.swift
Outdated
| } | ||
| .textCase(.uppercase) | ||
| .help("InstallDescription") | ||
| }.buttonStyle(AppStoreButtonStyle(primary: false, highlighted: false)) |
Contributor
There was a problem hiding this comment.
Sorry one last change @chickdan - can we move this buttonStyle outside of ProgressButton. This would be set on the XcodeListViewRow but not set for the infoPane buttons.
That will keep all the buttons the same style on the infoPane. Thanks
Contributor
Author
There was a problem hiding this comment.
Good catch! Updated.
MattKiazyk
approved these changes
Dec 13, 2023
|
GitHub pro tip @chickdan: if you put something like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that there is often a long delay between clicking Install and the button switching to the linear progress view which sometimes makes it seem unresponsive. So I added a circular style progress view to the install button to indicate activity and reduce the chance of repeat clicks.
Before:
After:
