Add installation progress bar to dock icon#423
Merged
MattKiazyk merged 4 commits intoXcodesOrg:mainfrom Nov 22, 2023
Merged
Conversation
added 2 commits
September 13, 2023 12:48
to track both downloading and unarchiving and reflect this in dock progress
9ecea13 to
622fac6
Compare
Contributor
Author
MattKiazyk
approved these changes
Nov 22, 2023
Contributor
|
Thanks a bunch @senmu (sorry for the late response) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17
Uses suggested DockProgress to display a progress bar overlay on top of the dock icon as an Xcode is downloading.
Successor to #85. A new
overallProgresshas been pulled up to track the downloading and the unarchive portion of installing an Xcode. Within theoverallProgressthe following weights are applied:Below are some previews:
During download
During unarchiving
During the post-installation/finishing steps
These final steps require user interaction so no new child
Progressobjects were created to track these. However, you can see that once it gets here, the progress bar is gone.