Enable text selection for Xcode version#416
Closed
yo1995 wants to merge 3 commits intoXcodesOrg:mainfrom
yo1995:yo1995/Update-EnableTextSelection
Closed
Enable text selection for Xcode version#416yo1995 wants to merge 3 commits intoXcodesOrg:mainfrom yo1995:yo1995/Update-EnableTextSelection
yo1995 wants to merge 3 commits intoXcodesOrg:mainfrom
yo1995:yo1995/Update-EnableTextSelection
Conversation
MattKiazyk
reviewed
Nov 22, 2023
|
|
||
| Text(verbatim: "Xcode \(xcode.description) \(xcode.version.buildMetadataIdentifiersDisplay)") | ||
| .font(.title) | ||
| .textSelection(.enabled) |
Contributor
There was a problem hiding this comment.
.textSelection is only available on MacOS 12. Currently Xcodes has a minimum version of 11.
You can either wrap this in a #available or this PR can wait a bit. Some point soon we'll update to min of 12.
Author
There was a problem hiding this comment.
Thanks! It was an oversight from my part - I only saw the "build with macOS 12" part in README, but didn't read the "run on macOS 11.0" line 😅
I'll defer it to your decision - feel free to wait min target becomes macOS 12 or edit this PR with
private extension InfoPane {
@ViewBuilder
func textSelection(_ enabled: Bool) -> some View {
if #available(macOS 12, *), enabled {
self
.textSelection(.enabled)
} else {
self
}
}
}
MattKiazyk
requested changes
Nov 22, 2023
Contributor
MattKiazyk
left a comment
There was a problem hiding this comment.
Thanks!
See comment around macOS 12 vs 11
Contributor
|
This has been added via #503 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #415