FEDX-2835: Fixed issues from release#264
Merged
btr-rmconsole-5[bot] merged 1 commit intomasterfrom Mar 20, 2025
Merged
Conversation
| jobs: | ||
| checks: | ||
| uses: Workiva/gha-dart-oss/.github/workflows/checks.yaml@v0.1.3 | ||
| uses: Workiva/gha-dart-oss/.github/workflows/checks.yaml@v0.1.7 |
Contributor
Author
There was a problem hiding this comment.
v0.1.3 does not have the CHANGELOG check to address the missing changes
| build_web_compilers: '>=3.0.0 <5.0.0' | ||
| dart_dev: ^4.0.0 | ||
| dart_style: ^2.1.1 | ||
| dependency_validator: ^3.2.2 |
Contributor
Author
There was a problem hiding this comment.
dep validator is installed globally
bender-wk
changed the title
alanknight-wk
approved these changes
Mar 20, 2025
Contributor
Author
|
QA +1 CI does indeed pass, only changes are to CI |
Contributor
Author
|
🚀 @Workiva/release-management-p 🚢 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FEDX-2835
Motivation
Release CI is failing due to missing CHANGELOG entries. There is a check in gha-dart-oss which prevents this, but its in a more recent version
This PR updates w_module to use the latest gha-dart-oss to implement the check to catch the release errors before the release PR is merged
Merge Checklist