Skip to content

Conversation

@gersona
Copy link
Contributor

@gersona gersona commented Nov 23, 2025

@gersona gersona force-pushed the 15801_format_encoding_params branch 6 times, most recently from 48c51c8 to adf1d42 Compare December 4, 2025 16:22
@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

❌ Patch coverage is 94.89796% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.73%. Comparing base (4dcb9a3) to head (64850be).

Files with missing lines Patch % Lines
weblate/formats/ttkit.py 91.80% 4 Missing and 1 partial ⚠️
weblate/trans/file_format_params.py 92.30% 4 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (94.89%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gersona gersona force-pushed the 15801_format_encoding_params branch from 37413dd to c303d8c Compare December 8, 2025 05:28
@gersona gersona marked this pull request as ready for review December 8, 2025 06:17
@gersona gersona requested a review from AliceVisek as a code owner December 8, 2025 06:17
@nijel nijel requested a review from Copilot December 8, 2025 07:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@nijel nijel added this to the 5.15 milestone Dec 11, 2025
@nijel nijel self-assigned this Dec 11, 2025
@nijel
Copy link
Member

nijel commented Dec 11, 2025

Let's try to include this in 5.15. I forgot to review this, so most of the delay is on my side...

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 24 out of 24 changed files in this pull request and generated 3 comments.

@nijel
Copy link
Member

nijel commented Dec 12, 2025

I broke the migrations once again :-). Fixed that now.

@gersona
Copy link
Contributor Author

gersona commented Dec 12, 2025

I also just broke something as well

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 24 out of 24 changed files in this pull request and generated 6 comments.

@nijel nijel modified the milestones: 5.15, 5.16 Dec 12, 2025
@nijel
Copy link
Member

nijel commented Dec 12, 2025

Okay, let's not rush with this for 5.15. Most of the Copilot feedback makes sense, so let's look deeper.

@gersona gersona force-pushed the 15801_format_encoding_params branch from 62da88d to 04944ed Compare December 18, 2025 13:09
@gersona gersona force-pushed the 15801_format_encoding_params branch from e9c55d6 to 64850be Compare December 19, 2025 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use parameters for file format encoding

2 participants