Disable all BigInt tests except bigint-noble-ed25519 by default #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
camillobruni
approved these changes
May 13, 2025
JetStreamDriver.js
Outdated
| if (!benchmark) | ||
| throw "Couldn't find test named \"" + testName + "\""; | ||
|
|
||
| if (!forceEnable && benchmark.disabledByDefault) |
Contributor
There was a problem hiding this comment.
nit: would we ever not forceEnable workloads?
Contributor
Author
There was a problem hiding this comment.
We don't but I had the argument to be consistent. I'll remove.
Contributor
|
LGTM also. |
bigint-noble-ed25519 is the remaining BigInt test enabled by default as it appears to do the most interesting things with BigInts. The rest are now disabled by default. They will run if they're passed via a test list but are otherwise not enabled. To make this work there's a new property on `Benchmark`s/`plan`s that disables them by default.
kmiller68
force-pushed
the
disable-extra-bigint-tests
branch
from
49bbe51 to
ff88901
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've decided we're only going to keep one BigInt test for now. bigint-noble-ed25519 is the remaining BigInt test enabled by default as it appears to do the most interesting things with BigInts. The rest are now disabled by default. They will run if they're passed via a test list but are otherwise not enabled.
To make this work there's a new property on
Benchmarks/plans that disables them by default.