Move HashSet-wasm to first, worst, average scoring #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eqrion
approved these changes
Jan 24, 2025
Same steps as for the other Wasm line items: - Move files to subdirectory. - Rebuild with up-to-date Emscripten. - Reduce single iteration time, so that we can run multiple iterations (a single iteration before took ~300ms, now ~30ms). - Checked that we spend roughly the same amount of CPU samples in the top-tier and that overall profiles look similar.
danleh
force-pushed
the
hashset-wasm-scoring
branch
from
1d9e77c to
daf59cd
Compare
Contributor
Author
|
Conflicts resolved after #13 was merged. @kmiller68 Please merge if it looks good to you. CI seems to be failing independent of this PR, see https://github.com/WebKit/JetStream/actions. @camillobruni |
kmiller68
approved these changes
Jan 27, 2025
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same steps as for the other Wasm line items:
Once #28 and this lands, all Wasm line items of JetStream 2 have been moved over to the new scoring. So we can start measuring and (if needed) do a round of adapting workload sizes/iteration counts.
CC @kmiller68 @eqrion