Fix proxy used in memory constructor test#236
Closed
backes wants to merge 1 commit intoWebAssembly:main-legacyfrom
Closed
Fix proxy used in memory constructor test#236backes wants to merge 1 commit intoWebAssembly:main-legacyfrom
backes wants to merge 1 commit intoWebAssembly:main-legacyfrom
Conversation
Another targeted fix to make this file pass in V8. This was fixed upstream already, so alternatively we could rebase the whole repository.
Member
Author
|
See #235 for the first fix in this file. After those two fixes, this passes in V8 (and there are two remaining failures in V8). |
Collaborator
|
Same comment as #235 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another targeted fix to make this test pass in V8. This was fixed upstream already, so alternatively we could rebase the whole repository.