Conversation
sbc100
force-pushed
the
table64_interp
branch
3 times, most recently
from
d5fcb12 to
ce08751
Compare
|
I didn't end up duplicating all of the table.* tests here but just enough to get a little coverage for each instruction. Let me know if you think its worth duplicating more. |
rossberg
left a comment
rossberg
left a comment
There was a problem hiding this comment.
LGTM, mostly nits, except for the question about the table size limit.
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
Poking at this I think there's one issue I flagged below, but mind also adding tests for table.copy? That'll likely want to inherit the same logic for memory.copy where the src/dst offsets have static types but the length-to-copy is the minimum of the two sizes.
| (table.init $t0 1 (i32.const 7) (i32.const 0) (i32.const 4))) | ||
| (table.init $t0 2 (i32.const 7) (i32.const 0) (i32.const 4))) | ||
| (func (export "test-t64") | ||
| (table.init $t64 2 (i32.const 7) (i32.const 0) (i32.const 4))) |
There was a problem hiding this comment.
I think this trailing i32.const needs to be i64.const?
There was a problem hiding this comment.
Thanks for catching.. taking a look now.
Add missing memory specifier to memory.init execution semantics
3 participants
No description provided.