Skip to content

[NFC] Avoid a temp local#6800

Merged
kripken merged 2 commits intoWebAssembly:mainfrom
kripken:fix.warn
Aug 1, 2024
Merged

[NFC] Avoid a temp local#6800
kripken merged 2 commits intoWebAssembly:mainfrom
kripken:fix.warn

Conversation

@kripken
Copy link
Member

@kripken kripken commented Aug 1, 2024

The local was only used once, so it didn't really add much. And, it was causing some
compilers to error on "unused variable" (when building without assertions, the use
was removed).

@kripken kripken requested a review from tlively August 1, 2024 18:31
@kripken
Copy link
Member Author

kripken commented Aug 1, 2024

Landing to fix breakage.

@kripken kripken merged commit 705c28d into WebAssembly:main Aug 1, 2024
@kripken kripken deleted the fix.warn branch August 1, 2024 18:56
@tlively
Copy link
Member

tlively commented Aug 1, 2024

LGTM! Another option is to use [[maybe_unused]].

@gkdn gkdn mentioned this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments