Add a customizable title to Metrics reporting#6792
Merged
kripken merged 4 commits intoWebAssembly:mainfrom Jul 30, 2024
Merged
Conversation
tlively
approved these changes
Jul 30, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the PR:
After the PR:
Note the "Metrics" addition at the top. And the title can be customized:
The custom title can be helpful when multiple invocations of metrics are used
at once, e.g.
--metrics=before -O3 --metrics=after.This is now trivial to do, after #6687
cc @gkdn , I believe you asked for something like this in the past.