Generalize Literal::externalize/internalize for strings and shareability#6784
Generalize Literal::externalize/internalize for strings and shareability#6784kripken merged 8 commits intoWebAssembly:mainfrom
Conversation
|
It is worth testing shared i31s (which will reveal that the assertion at the beginning of |
|
Ok, I added testing for shared i31. That found a few more places that needed shareability fixes. |
tlively
left a comment
There was a problem hiding this comment.
One thing to note is that now that we are closer to being able to run and directly import the upstream spec tests, any additional testing we add to our own spec tests will be able to eventually benefit everyone.
Co-authored-by: Thomas Lively <tlively123@gmail.com>
|
ASan tests found another issue with shareability, in a destructor. Fixed. @tlively I am getting a little worried that we may have many more places with |
|
Good idea, I will take a look. |
Is it worth testing shareability here? (is the fuzzer ready?)