Conversation
kripken
approved these changes
Jul 12, 2024
test/lit/i31-new.wast
Outdated
| ;; NOTE: Assertions have been generated by update_lit_checks.py and should not be edited. | ||
|
|
||
| ;; Check that we still parse the legacy i31.new instruction. | ||
| ;; Check that we still parse the legacy ref.i31 instruction. |
Member
There was a problem hiding this comment.
Is this test still needed? ref.i31 is not legacy.
tlively
force-pushed
the
threads-shared-i31
branch
from
6fadc97 to
f05017d
Compare
kripken
approved these changes
Jul 12, 2024
The standard name for the instruction is `ref.i31`. Remove support for the non-standard name and update tests that were still using it.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The standard name for the instruction is
ref.i31. Remove support forthe non-standard name and update tests that were still using it.