wasm2js: Fix the names of temp vars with named reference types#6689
Merged
kripken merged 2 commits intoWebAssembly:mainfrom Jun 21, 2024
Merged
wasm2js: Fix the names of temp vars with named reference types#6689kripken merged 2 commits intoWebAssembly:mainfrom
kripken merged 2 commits intoWebAssembly:mainfrom
Conversation
tlively
approved these changes
Jun 21, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were missing code to mangle such names for JS. Without that, the name
of a temp var for the type
(ref $foo)would end up with(,)in the name, whichis not valid in JS.
(See last commit for the effect of the one-line change.)