[WIP] ReFinalize GlobalGet in initializers after GlobalRefining#6566
Closed
[WIP] ReFinalize GlobalGet in initializers after GlobalRefining#6566
Conversation
When GlobalRefining refines the type of a global, it updates the type of corresponding GlobalGet expressions, then runs ReFinalize to propagate the refined types. However, it only performed these updates in function bodies, leaving stale types on GlobalGet expressions in constant initializers. This bug was not easily caught because the validator did not check that `GlobalGet` types actually match the types of the corresponding globals. Fix the validator to check the types of `GlobalGet` expressions and fix GlobalRefining to properly update constant initializers. Fixes #6565.
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Member
Author
|
So far this fixes the validator and adds a failing test, but does not actually fix GlobalRefining yet. Once GlobalRefining is fixed to refinalize global initializers, it will open up the possibility of further refining the globals whose initializers depend on previously refined globals. @kripken, do you think it is worth iterating to a fixed point in this pass? |
Member
|
Good find! Yeah, when we are missing validation then these bugs can be hard to figure out (and my guess at the cause here was way off...). Iterating to a fixed point makes sense I think, unless there is some complexity I am missing. |
Member
Author
|
Superseded by #6603 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When GlobalRefining refines the type of a global, it updates the type of
corresponding GlobalGet expressions, then runs ReFinalize to propagate the
refined types. However, it only performed these updates in function bodies,
leaving stale types on GlobalGet expressions in constant initializers. This bug
was not easily caught because the validator did not check that
GlobalGettypesactually match the types of the corresponding globals.
Fix the validator to check the types of
GlobalGetexpressions and fixGlobalRefining to properly update constant initializers.
Fixes #6565.