[wasm-split] Do not split out functions referring to segments#6517
Merged
[wasm-split] Do not split out functions referring to segments#6517
Conversation
Since data and elem segments cannot be imported or exported, there is no way to access them from the secondary module, so functions that need to refer to them cannot be split out. Fixes #6512.
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
kripken
approved these changes
Apr 22, 2024
Member
kripken
left a comment
There was a problem hiding this comment.
Another option might be to export from the primary module methods that do a drop etc., and call those from the secondary module. If these operations are common we might want to do that, but I'm not sure if they are?
Member
Author
|
That's a good idea, too. Another possibility I thought of was to do an analysis to see if the segment could be moved (rather than copied) to the secondary module. I think these instructions are rare so far, so it's not worth doing anything complicated, but if e.g. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Since data and elem segments cannot be imported or exported, there is no way to
access them from the secondary module, so functions that need to refer to them
cannot be split out.
Fixes #6512.