Fuzzer: Emit signed Struct/ArrayGet operations#6486
Merged
kripken merged 3 commits intoWebAssembly:mainfrom Apr 11, 2024
Merged
Fuzzer: Emit signed Struct/ArrayGet operations#6486kripken merged 3 commits intoWebAssembly:mainfrom
kripken merged 3 commits intoWebAssembly:mainfrom
Conversation
tlively
approved these changes
Apr 10, 2024
This was referenced Apr 11, 2024
kripken
added a commit
that referenced
this pull request
Apr 11, 2024
… Heap2Local's (#6493) CFP already had logic for truncating but not for sign-extending, which this fixes. Use the new helper function in Heap2Local as well. This changes the model there from "truncate on set, sign-extend on get" to "truncate or sign-extend on get". That is both simpler by reusing the same logic as CFP but also more optimal: the idea to truncate on sets made sense since sets are rarer, but if we must then sign-extend on gets then we can end up doing more work overall (as the truncations on sets are not needed if all gets are signed). Found by #6486
kripken
added a commit
that referenced
this pull request
Apr 11, 2024
Member
Author
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would have found the bug in #6480 fairly easily (confirmed as finding it
within a few minutes).