GUFA: Fix hashing of GlobalInfo's type#6455
Merged
kripken merged 3 commits intoWebAssembly:mainfrom Mar 29, 2024
Merged
Conversation
tlively
approved these changes
Mar 29, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See lines 69-70 in that header: For a global we store the name and a type,
and the type may be more precise than the global's type in the wasm. As
a result, when hashing, it is not enough to hash only the name, so hash
the type as well.
Not sure if this caused any significant issues due to more hash collisions,
but I noticed it while reading the code.
Also add a random TODO as a comment.