[Strings] Emit unreachable when a string instruction cannot be emitted properly#6415
[Strings] Emit unreachable when a string instruction cannot be emitted properly#6415kripken merged 1 commit intoWebAssembly:mainfrom
Conversation
tlively
left a comment
There was a problem hiding this comment.
Possibly worth doing this in the printer as well for consistency. WDYT?
|
Hmm, I think it might be best not to. We print an unreachable for text when we have to, like |
|
I guess so, but we'd have to fix it anyway if not for the spec bug that there is no annotation. I'm half tempted to say we should just add the annotation and pretend the spec bug has already been fixed, but that sounds like more trouble than it's worth. Anyway, I don't feel too strongly about it. |
|
I see. Yeah, if the spec gets changed we'd need to do this. Anyhow, for now this is just more convenient (both less work and more roundtripping). |
See WebAssembly/stringref#66