Tests/Fuzzing: Remove some obsolete experimental V8 flags#6347
Merged
kripken merged 1 commit intoWebAssembly:mainfrom Feb 28, 2024
Merged
Tests/Fuzzing: Remove some obsolete experimental V8 flags#6347kripken merged 1 commit intoWebAssembly:mainfrom
kripken merged 1 commit intoWebAssembly:mainfrom
Conversation
aheejin
approved these changes
Feb 28, 2024
Member
aheejin
left a comment
There was a problem hiding this comment.
I think it should be fine given that the only place V8_OPTS is used in fuzz_opt.py.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those flags were removed in V8 as the features are no longer experimental. This
PR removes this noise from our logs:
However, older versions of V8 may not work any more without those flags. I
always test on a recent one, and I'm not sure if we have a use for anything
else?