C API: Support adding data segment individually#6346
Merged
kripken merged 1 commit intoWebAssembly:mainfrom Feb 28, 2024
mobsceneZ:addDataSegments
Merged
C API: Support adding data segment individually#6346kripken merged 1 commit intoWebAssembly:mainfrom mobsceneZ:addDataSegments
kripken merged 1 commit intoWebAssembly:mainfrom
mobsceneZ:addDataSegments
Conversation
kripken
reviewed
Feb 27, 2024
| const char* segmentData, | ||
| bool segmentPassive, | ||
| BinaryenExpressionRef segmentOffset, | ||
| BinaryenIndex segmentSize); |
Member
There was a problem hiding this comment.
Perhaps it would be clearer to reorder segmentData next to segmentSize? In general matching the order of wasm-builder's makeDataSegment seems the most predictable.
Contributor
Author
There was a problem hiding this comment.
Perhaps it would be clearer to reorder
segmentDatanext tosegmentSize? In general matching the order ofwasm-builder'smakeDataSegmentseems the most predictable.
@kripken, I have made corresponding changes and you can check that out :)
kripken
approved these changes
Feb 28, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intended to fix issue #6314.