Merged
Conversation
tlively
approved these changes
Dec 19, 2023
Member
tlively
left a comment
tlively
left a comment
There was a problem hiding this comment.
Change LGTM, but I don't understand how this could trip up the fuzzer without something else missing. How did the child of the drop end up being a tuple without multivalue enabled?
Member
Author
|
Good point, we must be missing validation for the child as well. Unfortunately, I've since resumed the fuzzer and it has overwritten the |
radekdoulik
pushed a commit
to dotnet/binaryen
that referenced
this pull request
Jul 12, 2024
Without this fuzzer testcases fail if the initial content has a tuple.drop but multivalue is disabled (then the initial content validates erroneously, and that content is remixed into more content using multivalue which fails to validate).
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this fuzzer testcases fail if the initial content has a
tuple.dropbut multivalueis disabled (then the initial content validates erroneously, and that content is remixed
into more content using multivalue which fails to validate).