Conversation
This was referenced Oct 30, 2023
Member
Author
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
This was referenced Oct 30, 2023
tlively
force-pushed
the
valtype-lattice
branch
from
3c29d25 to
2d99383
Compare
tlively
force-pushed
the
tuple-lattice
branch
from
b4d82c2 to
1458a3a
Compare
kripken
reviewed
Oct 31, 2023
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
valtype.h lgtm but I'm not sure what else I should review of these files?
|
|
||
| // A lattice whose elements are N-tuples of elements of L. Also written as L^N. | ||
| // N is supplied at compile time rather than run time like it is for Vector. | ||
| template<Lattice L, size_t N> struct Array { |
Add a lattice that is a thin wrapper around `wasm::Type` giving it the interface of a lattice. As usual, `Type::unreachable` is the bottom element, but unlike in the underlying API, we uniformly treat `Type::none` as the top type so that we have a proper lattice.
tlively
force-pushed
the
valtype-lattice
branch
from
2d99383 to
33139e2
Compare
Member
Author
|
Yep, overnight merge job for the previous PRs has messed up the diff here. Just pushed rebased versions to fix it. |
kripken
approved these changes
Oct 31, 2023
| break; | ||
| case 3: | ||
| type = Type::f32; | ||
| break; |
Member
Author
There was a problem hiding this comment.
I don't think adding them (or v128, or other reference types) would add much, since their relationships to other types isn't any different than what is already covered here.
Member
There was a problem hiding this comment.
Fair enough. Comment might be worthwhile as it's an obvious question for a reader of the code to have I think.
radekdoulik
pushed a commit
to dotnet/binaryen
that referenced
this pull request
Jul 12, 2024
Add a lattice that is a thin wrapper around `wasm::Type` giving it the interface of a lattice. As usual, `Type::unreachable` is the bottom element, but unlike in the underlying API, we uniformly treat `Type::none` as the top type so that we have a proper lattice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a lattice that is a thin wrapper around
wasm::Typegiving it the interfaceof a lattice. As usual,
Type::unreachableis the bottom element, but unlike inthe underlying API, we uniformly treat
Type::noneas the top type so that wehave a proper lattice.