Add an Asyncify option to propagate the addList#3794
Closed
curiousdannii wants to merge 1 commit intoWebAssembly:mainfrom
Closed
Add an Asyncify option to propagate the addList#3794curiousdannii wants to merge 1 commit intoWebAssembly:mainfrom
curiousdannii wants to merge 1 commit intoWebAssembly:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of emscripten-core/emscripten#13150
I'll be honest, I don't understand C++. I tried copying what the code did with
canIndirectChangeState, but I don't understand what it's doing at line 525 (534 of this PR). I'm hoping someone else who is able will be willing to turn this into a proper PR. Sorry!There was debate in the Emscripten issue whether a non-propagating mode is even useful. If it's not then the PR could be changed to just move where the addList is used.