Skip to content

Setup method of the models#59

Merged
gabrieletijunaityte merged 6 commits intodevelopfrom
feature/refactor-model-setup
Mar 5, 2026
Merged

Setup method of the models#59
gabrieletijunaityte merged 6 commits intodevelopfrom
feature/refactor-model-setup

Conversation

@gabrieletijunaityte
Copy link
Contributor

@gabrieletijunaityte gabrieletijunaityte commented Mar 5, 2026

What does this PR do?

Data-bound model configurations are now initialised and configured in the setup method of the model.

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?

@gabrieletijunaityte gabrieletijunaityte changed the title feature/refactor-model-setup Setup method of the models Mar 5, 2026
@gabrieletijunaityte gabrieletijunaityte marked this pull request as ready for review March 5, 2026 11:05
Copy link
Collaborator

@vdplasthijs vdplasthijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add an abstract setup() method to base_model for clarity? If it is just a pass for the base_model it should not affect anything else?

@gabrieletijunaityte gabrieletijunaityte merged commit cb58282 into develop Mar 5, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants