Conversation
| const progressIndicator = document.querySelector('#progress-indicator'); | ||
|
|
||
| const additionalScripts = [ | ||
| // Add additional scripts here. |
There was a problem hiding this comment.
Note: This is where we could "insert" the value of the array that would be optional.
erickzanardo
dismissed stale reviews from wolfenrain and renancaraujo
via
3c43929
Co-authored-by: Jochum van der Ploeg <jochum@vdploeg.net>
.github/dependabot.yaml
Outdated
| directory: "/" | ||
| schedule: | ||
| interval: "daily" | ||
| - package-ecosystem: "pub" |
There was a problem hiding this comment.
I don't think this will do anything because there's no pubspec.yaml at the root of the project.
There was a problem hiding this comment.
Good point, do we have anything for bricks? Or should I just remove this action as a whole?
There was a problem hiding this comment.
I've removed the file!
| uses: VeryGoodOpenSource/very_good_workflows/.github/workflows/dart_package.yml@v1 | ||
| with: | ||
| working_directory: hooks | ||
| analyze_directories: . |
There was a problem hiding this comment.
Yeah, the default is lib test, so it would not analyse the pre_gen.dart file
| 'canvaskit/canvaskit.wasm', | ||
| 'canvaskit/canvaskit.js', |
There was a problem hiding this comment.
Should we make canvaskit configurable? If we're using the html renderer it shouldn't be necessary right?
There was a problem hiding this comment.
Oh, good catch, I will do that, but I will keep canvaskit as true by default, cause, tbh, I see almost no reason to use this when using web renderers, makes sense?
felangel
left a comment
felangel
left a comment
There was a problem hiding this comment.
Overall LGTM just left a few minor comments.
Co-authored-by: Felix Angelov <felangelov@gmail.com>
4 participants
Adds the initial implementation of the brick