Skip to content

Fix json format#131

Merged
XkunW merged 2 commits intomainfrom
fix-json-format
Aug 21, 2025
Merged

Fix json format#131
XkunW merged 2 commits intomainfrom
fix-json-format

Conversation

@scarere
Copy link

@scarere scarere commented Aug 21, 2025

PR Type

[Feature | Fix | Documentation | Other() ]

Short Description

The --json-mode flag of the vec-inf status command was outputting string literals with single quotes, which is not compatible with json which requires double quotes. This fixes that issue ensuring output is json compliant.

Tests Added

Fixed two tests that were asserting that input to click.echo was a dict, now they assert that input is a json compatible string that can be converted to a dictionary using json.loads.

@scarere scarere requested a review from XkunW August 21, 2025 15:47
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.90%. Comparing base (e28a9d3) to head (284454f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
+ Coverage   91.89%   91.90%   +0.01%     
==========================================
  Files          14       14              
  Lines        1147     1149       +2     
==========================================
+ Hits         1054     1056       +2     
  Misses         93       93              
Files with missing lines Coverage Δ
vec_inf/cli/_helper.py 100.00% <100.00%> (ø)

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@XkunW XkunW merged commit 28808fe into main Aug 21, 2025
7 checks passed
@XkunW XkunW deleted the fix-json-format branch August 21, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants