Merged
Conversation
bencap
added
type: enhancement
bencap
force-pushed
the
feature/bencap/35/api-like-target-category-constant
branch
from
522a695 to
5809ba4
Compare
jstone-dev
approved these changes
Nov 12, 2024
Collaborator
jstone-dev
left a comment
jstone-dev
left a comment
There was a problem hiding this comment.
Looks good. I wondered at first if we really want to use custom types in the database, but on second thought it seemed like a good idea in this case to ensure correctness.
Collaborator
Author
|
Yeah, I was kinda torn too. I think where I fall is that I like the enums for fields that are their own database column. It's also nice to have them to take advantage of some built in pydantic validation on enum types. |
bencap
deleted the
feature/bencap/35/api-like-target-category-constant
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.