Always Create a New Gene Normalizer Instance#24
Merged
bencap merged 1 commit intomavedb-mainfrom Oct 16, 2024
Merged
Conversation
bencap
added
type: bug
sallybg
reviewed
Oct 14, 2024
src/dcd_mapping/lookup.py
Outdated
|
|
||
| :return: singleton instance of ``QueryHandler`` for Gene Normalizer | ||
| """ | ||
| if not hasattr(cls, "instance"): |
Collaborator
There was a problem hiding this comment.
Should this be if hasattr(cls, "instance"): ?
Collaborator
Author
There was a problem hiding this comment.
Oops, yes it should.
This is to avoid instances where the database connection has been prematurely closed. Since the gene normalizer instance uses an internal abstract database class and we don't expect this operation to occur too often, it is simpler to just close the existing database connection ourselves and respawn the instance in cases where it already exists.
bencap
force-pushed
the
feature/bencap/23/gene-normalizer-connection-often-closed
branch
from
edf2c3a to
7dc6ed0
Compare
bencap
deleted the
feature/bencap/23/gene-normalizer-connection-often-closed
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to avoid instances where the database connection has been prematurely closed. Since the gene normalizer instance uses an internal abstract database class and we don't expect this operation to occur too often, it is simpler to just close the existing database connection ourselves and respawn the instance in cases where it already exists.