Skip to content

Conversation

@cvanelteren
Copy link
Collaborator

#98 Addresses an issue where explicit key word is given or not. By default the first argument is assumed to be the color spec but that does not have to be the case.

@cvanelteren cvanelteren mentioned this pull request Feb 25, 2025
Copy link
Collaborator

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs to add the exact test case from the original issue.

@cvanelteren
Copy link
Collaborator Author

They are in there. Just refactored and expanded.

@cvanelteren cvanelteren requested a review from beckermr February 25, 2025 16:42
Copy link
Collaborator

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this test

def test_cycler_factory():
    """Test the factory function that creates cycler objects"""
    # Test basic factory creation
    cycler = uplt.Cycle(colors=["red", "blue"])
    assert isinstance(cycler, uplt.Cycle)

but it doesn't check the list of colors coming out. Please add that.

@cvanelteren
Copy link
Collaborator Author

assert props1["color"] != props2["color"] # color should cycle

This line does it. But I will make it more explicit.

@beckermr beckermr enabled auto-merge (squash) February 25, 2025 17:00
@beckermr beckermr merged commit 1457a2e into Ultraplot:main Feb 25, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants