fix: remove race condition for pushes of tags #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvanelteren
previously requested changes
Feb 15, 2025
Collaborator
cvanelteren
left a comment
cvanelteren
left a comment
There was a problem hiding this comment.
The path is issue is caused by the racing condition? The test workflow contains the path directly.
Collaborator
Author
|
The race condition is duplicate uploads to test pypi, not the path thing you fixed. |
Collaborator
|
Any clue why the test fails? |
Collaborator
|
Ah I think I might. Will fix. LGTM |
cvanelteren
dismissed
their stale review
the raised error is caused by the seed not being used causing potential different image to be generated on the workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed one of the race conditions.