use norm explicitly #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckermr
requested changes
Feb 14, 2025
Collaborator
beckermr
left a comment
beckermr
left a comment
There was a problem hiding this comment.
For this one, we should compare the output figures directly as well.
Collaborator
Author
|
As in make the test an image compare? |
Collaborator
|
Yes. It will be a no-op in this case, but will catch any regressions in the future. |
Collaborator
Author
|
The test will fail due to a newly added test (probably). |
beckermr
reviewed
Feb 14, 2025
beckermr
approved these changes
Feb 14, 2025
Collaborator
beckermr
left a comment
beckermr
left a comment
There was a problem hiding this comment.
test failure is indeed expected and correct. LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #75