Skip to content

Conversation

@beckermr
Copy link
Collaborator

@beckermr beckermr commented Feb 3, 2025

This PR switches the images to use full urls so the readme works on pypi.

closes #66

@cvanelteren
Copy link
Collaborator

Version('1.0.6.dev5+gf87b56a4')> is not allowed.

@cvanelteren
Copy link
Collaborator

Otherwise approved. Feel free to merge when ready or ping me when required.

@beckermr
Copy link
Collaborator Author

beckermr commented Feb 3, 2025

Thanks for the review @cvanelteren. The test pypi upload I did looks good.

Screenshot 2025-02-02 at 11 09 29 PM

@beckermr beckermr marked this pull request as ready for review February 3, 2025 05:11
@beckermr beckermr enabled auto-merge (squash) February 3, 2025 05:11
@cvanelteren
Copy link
Collaborator

Looks good 😍

@beckermr beckermr merged commit 0b54a4f into main Feb 3, 2025
12 checks passed
@beckermr beckermr deleted the fix-readme branch February 3, 2025 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix logo and images on pypi

3 participants