Skip to content

add case where cycler is already a cycle #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cvanelteren merged 6 commits into from
Feb 2, 2025
Merged

add case where cycler is already a cycle #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7af61b7
add case where cycler is already a cycle
cvanelteren Feb 2, 2025
9cd5139
Merge branch 'main' into cycle-hotfix
beckermr Feb 2, 2025
4d43ce0
convert all to internal cycler; and add test
cvanelteren Feb 2, 2025
f563965
cleanup
cvanelteren Feb 2, 2025
b247774
fix typo
cvanelteren Feb 2, 2025
b02e36d
rm kw
cvanelteren Feb 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ultraplot/axes/plot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2485,6 +2485,8 @@ def _parse_cycle(
resolved_cycle = None
case str() | int():
resolved_cycle = constructor.Cycle(cycle, **cycle_kw)
case constructor.Cycle():
resolved_cycle = constructor.Cycle(cycle)
case _:
resolved_cycle = None

Expand Down
11 changes: 11 additions & 0 deletions ultraplot/tests/test_constructor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,3 +97,14 @@ def test_manual_cycle():
props = ax._active_cycle.get_next()
assert cycled_pos == parser._idx
assert props == parser._cycler_items[parser._idx]


def test_pass_on_cycle():
colors = ["red", "green", "black"]
cycle = uplt.Cycle(colors)
fig, ax = uplt.subplots()
ax.set_prop_cycle(cycle)
active_cycle = ax.axes._active_cycle
for color in colors:
assert color == active_cycle.get_next()["color"]
assert color == cycle.get_next()["color"]
Loading