Skip to content

Conversation

@cvanelteren
Copy link
Collaborator

This fixes #56 as it was creating a dependency between test and prod whereas test was trigger on tags whereas prod is triggered on release. Furthermore this integrates the two rather than having tags and releases

@cvanelteren
Copy link
Collaborator Author

What do you think of letting go of release and just using tags @beckermr ?

@beckermr
Copy link
Collaborator

I am confused. Can you explain the issue more clearly?

@cvanelteren
Copy link
Collaborator Author

Currently prod is pushed only when testpy is finished, but they are both run on different conditions. Test is run on tag releases whereas prod is run on releases. So it ends up being mutually exclusive.

@cvanelteren
Copy link
Collaborator Author

To continue. We currently have releases and tags, but one of them is sufficient I think. We can let one go and still keep the dep between uploading to test (catching potential issues) and releasing to pypi.

Copy link
Collaborator

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use this for the if condition to solve this problem

if: github.event_name == 'push' || github.event_name == 'release'

@beckermr
Copy link
Collaborator

We should keep the official releases on github.

@cvanelteren cvanelteren enabled auto-merge (squash) January 31, 2025 17:41
@cvanelteren cvanelteren disabled auto-merge January 31, 2025 17:42
@cvanelteren cvanelteren enabled auto-merge (squash) January 31, 2025 17:42
Copy link
Collaborator

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the build-sucess step is in the wrong file.

@beckermr
Copy link
Collaborator

We should back out that latest change and just merge my other PR.

@beckermr beckermr disabled auto-merge January 31, 2025 18:38
@beckermr beckermr enabled auto-merge (squash) January 31, 2025 18:39
@beckermr beckermr merged commit f7c7c83 into Ultraplot:main Jan 31, 2025
10 checks passed
@cvanelteren cvanelteren deleted the dep-build branch February 27, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publish to pypi still being skipped

2 participants