-
Notifications
You must be signed in to change notification settings - Fork 19
Dep build #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dep build #57
Conversation
ab2932c to
724b056
Compare
|
What do you think of letting go of release and just using tags @beckermr ? |
|
I am confused. Can you explain the issue more clearly? |
|
Currently prod is pushed only when testpy is finished, but they are both run on different conditions. Test is run on tag releases whereas prod is run on releases. So it ends up being mutually exclusive. |
|
To continue. We currently have releases and tags, but one of them is sufficient I think. We can let one go and still keep the dep between uploading to test (catching potential issues) and releasing to pypi. |
beckermr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use this for the if condition to solve this problem
if: github.event_name == 'push' || github.event_name == 'release'
|
We should keep the official releases on github. |
beckermr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the build-sucess step is in the wrong file.
|
We should back out that latest change and just merge my other PR. |
This fixes #56 as it was creating a dependency between test and prod whereas test was trigger on tags whereas prod is triggered on release. Furthermore this integrates the two rather than having tags and releases