Skip to content

Conversation

@beckermr
Copy link
Collaborator

@beckermr beckermr commented Jan 30, 2025

This PR removes the locale matrix elements and adds matplotlib ones.

We cannot yet add MPL 3.10 due to basemap. I have left a comment in the code.

closes #50
closes #49

@beckermr beckermr marked this pull request as ready for review January 30, 2025 23:18
@beckermr beckermr requested a review from cvanelteren January 30, 2025 23:19
@beckermr beckermr changed the title test: adjust test matrix to use one locale and multiple MPL versions test: adjust test matrix to use one locale and add matrix dimension over MPL versions Jan 30, 2025
@beckermr
Copy link
Collaborator Author

@cvanelteren This PR is ready to merge!

Copy link
Collaborator

@cvanelteren cvanelteren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments left

@cvanelteren
Copy link
Collaborator

Sorry for the noise, but think this works.

@cvanelteren cvanelteren self-requested a review January 31, 2025 17:53
Copy link
Collaborator Author

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not merge. I want to use the mpl version in the deps instead of the markers.

@beckermr
Copy link
Collaborator Author

OK @cvanelteren This one is ready to merge

@beckermr beckermr enabled auto-merge (squash) January 31, 2025 18:22
@beckermr beckermr merged commit e5e4e59 into main Jan 31, 2025
10 checks passed
@beckermr beckermr deleted the build-matrix-fix branch January 31, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test against matrix of MPL versions set locale in CI

3 participants