Open
Conversation
…th_upstream_0_5_3
antoniojrossi
requested review from
AngelVlc,
evgeniy-trebin,
jrsahuquillo and
vkinelev
AngelVlc
approved these changes
Nov 18, 2024
jrsahuquillo
approved these changes
Nov 19, 2024
| if v.nil? && !column.nullable? | ||
| fail Errors::NonNullableColumnIsNullError, | ||
| "Column #{column.inspect} is NULL on record #{@record.inspect}. "\ | ||
| "Column #{column.inspect} is NULL on record #{@record.send(inspect_method)}. "\ |
There was a problem hiding this comment.
Calling a private method using send feels a bit fishy; perhaps it makes sense to make the method protected and use as usual?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates our fork of order_query gem with upstream changes up until 0.5.4. This is done to make it work with Rails version 7.X used in Backend application.