Skip to content

Comments

Restyle perf: Use StrictData for all modules that define data types.#82

Closed
restyled-io[bot] wants to merge 2 commits intomasterfrom
restyled/strict-data
Closed

Restyle perf: Use StrictData for all modules that define data types.#82
restyled-io[bot] wants to merge 2 commits intomasterfrom
restyled/strict-data

Conversation

@restyled-io
Copy link

@restyled-io restyled-io bot commented Dec 1, 2021

A duplicate of #81 with additional commits that automatically address
incorrect style, created by Restyled.

⚠️ Even though this PR is not a Fork, it contains outside contributions.
Please review accordingly.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions
    ```console
    git remote add upstream https://github.com/TokTok/hs-msgpack-binary.git
    git fetch upstream pull/<this PR number>/head
    git merge --ff-only FETCH_HEAD
    git push
    ```
    

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.


This change is Reviewable

iphydf and others added 2 commits December 1, 2021 20:53
I've added StrictData to some modules that don't currently define data
types, mostly by mistake, but it doesn't harm and avoids missing it in
the future.
@auto-add-label auto-add-label bot added the performance A code change that improves performance label Dec 1, 2021
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ iphydf
❌ restyled-commits
You have signed the CLA already but the status is still pending? Let us recheck it.

@restyled-io restyled-io bot closed this Dec 1, 2021
@restyled-io restyled-io bot deleted the restyled/strict-data branch December 1, 2021 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance A code change that improves performance

Development

Successfully merging this pull request may close these issues.

3 participants