Merged
Conversation
tinder-cfuller
requested review from
tinder-emanharoutunian and
tinder-garricnahapetian
tinder-cfuller
changed the title
tinder-emanharoutunian
approved these changes
Mar 11, 2024
| /// | ||
| /// - Note: Use ``layout(metrics:_:)`` to create a layout with one item and use ``layout(metrics:items:)`` for | ||
| /// multiple items. Call ``Layout/addItems(_:)-59mxv`` to add more items to the layout. | ||
| /// multiple items. Use ``Layout/addItem(_:)`` or ``Layout/addItems(items:)`` to add additional items to |
Contributor
There was a problem hiding this comment.
Curious—how we maintained linking behavior in the docs without the Xcode-provided ID appended to the method?
Collaborator
Author
There was a problem hiding this comment.
Those methods were renamed, but the rename PR did not update these docs. With the rename there is no ambiguity, therefore the IDs are not necessary.
tinder-garricnahapetian
approved these changes
Mar 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.