Add iPhone 14 Devices via new SnapshotTestingExtensions target#241
Merged
tinder-garricnahapetian merged 11 commits intomainfrom Apr 16, 2024
Merged
Add iPhone 14 Devices via new SnapshotTestingExtensions target#241tinder-garricnahapetian merged 11 commits intomainfrom
tinder-garricnahapetian merged 11 commits intomainfrom
Conversation
tinder-garricnahapetian
requested a review
from tinder-cfuller
as a code owner
tinder-emanharoutunian
previously approved these changes
Jan 2, 2024
tinder-igornovik
previously approved these changes
Jan 3, 2024
tinder-garricnahapetian
dismissed stale reviews from tinder-igornovik and tinder-emanharoutunian
via
63e2e63
tinder-garricnahapetian
force-pushed
the
add-iphone-14-devices
branch
from
ecc5234 to
63e2e63
Compare
Collaborator
tinder-cfuller
left a comment
tinder-cfuller
left a comment
There was a problem hiding this comment.
May you please create a new library product named SnapshotTestingExtensions to contain the new extensions? They will need to be made public in this case. The reason for this suggestion is so that other consumers may use the new device sizes as well. Thank you!
tinder-garricnahapetian
force-pushed
the
add-iphone-14-devices
branch
from
63e2e63 to
264a06c
Compare
tinder-igornovik
approved these changes
Apr 11, 2024
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
tinder-cfuller
previously approved these changes
Apr 16, 2024
Collaborator
tinder-cfuller
left a comment
tinder-cfuller
left a comment
There was a problem hiding this comment.
Some extraneous whitespace snuck in!
Collaborator
tinder-cfuller
left a comment
tinder-cfuller
left a comment
There was a problem hiding this comment.
And these as well!
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
tinder-cfuller
previously approved these changes
Apr 16, 2024
Collaborator
|
@tinder-garricnahapetian May you please also add https://github.com/Tinder/Layout/blob/main/Makefile#L32 Please change from Thank you! |
tinder-garricnahapetian
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.