Setting for only one service being AlwaysConnected#37
Merged
Timac merged 6 commits intoTimac:masterfrom Oct 2, 2024
Merged
Conversation
(Sorry for the layout constraint hassle)
…uring the loop. This fixes the issue where the services are not updated.
Owner
|
Thanks a lot for the great feature! I only needed to make a few minor tweaks to get it working. Layout constraints can indeed be tricky. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Currently, when I choose "Always auto connect" for one service, it toggles auto-connect for that service.
I would like to have an option, so that when I activate auto-connect for one service, it deactivates auto-connect for all other services. In other words, only one service should be in use at a time.
The reason behind this, is an attempt to simplify usage of VPNStatus for people who want to simply choose between two options:
Instead of maintaining a fork of my own, I'm trying to support this upstream, in the hopes that it is useful for others.
I could add the setting to the preference pane and it successfully updates the preference file on disk. Even though it made a mess of the
xibfile and a constraint didn't quite work out:I wasn't sure, however, where to add the logic for deactivating
AlwaysConnectedof all other services. I've put it in the preference persistence logic now and unfortunately it doesn't seem to do anything. When I toggle the services in the menu bar, nothing happens in the preferences file.Do you have any thoughts on this? I'll keep on digging, but I thought I'd share it for now.
(PS: I'm planning on generally simplifying the menu bar entries later on with another pull request. I have so many VPN services in my menu, so that I actually have to scroll through the menu bar entries to see them all. I could imagine making the list of services a little more concise)
Thank you for your time. Since your last major code update, this app really improved a lot!