When deploy_arn is not defined in the Gruntfile the value is undefined

[procedurallygenerated]

I use the FunctionName to deploy the code. The deploy_arn is undefined for me at this point.

Why don't we just check if the the deploy_arn is true. It cannot be 0, "", null or undefined anyway.

[Tim-B]

Hi Varun, thanks for the pull request!

Does this cause a bug of some sort? I don't think 0, "" or null are valid ARNs, so would it be best to fall back to FunctionName in those cases?

[procedurallygenerated]

That's right. My Gruntfile currently looks like this,

lambda_deploy: {
  default: {
    function: '<name>'
  }
}

Since the deploy_arn is not set in the grunt file the value of deploy_arn is undefined when it arrives at this check. Currently the code only checks for the value being null. Since undefined !== null both the deploy_arn and deploy_function get set to undefined and the deploy fails.

Switching the check to fails on all false values fixes this issue.

[Tim-B]

Thanks for reporting this issue, it will be fixed in the next release.

I've also added unit tests to validate this use case.