fix: compute path and id relative to parent for pathless layouts#6131
fix: compute path and id relative to parent for pathless layouts#6131schiller-manuel wants to merge 1 commit intomainfrom
Conversation
WalkthroughThe PR modifies path computation in the router generator for pathless layouts with real (non-virtual) parents, calculating Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (8)
🧰 Additional context used📓 Path-based instructions (2)**/*.{ts,tsx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.{js,ts,tsx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
🧠 Learnings (9)📓 Common learnings📚 Learning: 2025-10-08T08:11:47.088ZApplied to files:
📚 Learning: 2025-10-01T18:31:35.420ZApplied to files:
📚 Learning: 2025-12-17T02:17:47.423ZApplied to files:
📚 Learning: 2025-12-06T15:03:07.223ZApplied to files:
📚 Learning: 2025-12-06T15:03:07.223ZApplied to files:
📚 Learning: 2025-11-02T16:16:24.898ZApplied to files:
📚 Learning: 2025-12-17T02:17:47.423ZApplied to files:
📚 Learning: 2025-10-01T18:30:26.591ZApplied to files:
🧬 Code graph analysis (6)packages/router-generator/tests/generator/flat-route-group/routes/app.(compras)/compras_.ordenes.tsx (4)
packages/router-generator/tests/generator/flat-route-group/routes/app.(compras)/compras_._mas.divisiones.tsx (4)
packages/router-generator/tests/generator/flat-route-group/routes/__root.tsx (4)
packages/router-generator/src/generator.ts (1)
packages/router-generator/tests/generator/flat-route-group/routeTree.nonnested.snapshot.ts (1)
packages/router-generator/tests/generator/flat-route-group/routeTree.snapshot.ts (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (8)
Comment |
|
View your CI Pipeline Execution ↗ for commit 682694e
☁️ Nx Cloud last updated this comment at |
|
closing in favor of #6121 |
Summary by CodeRabbit
Bug Fixes
Tests
✏️ Tip: You can customize this high-level summary in your review settings.