fix(solid-router): apply style to link by birkskyum · Pull Request #5628 · TanStack/router

birkskyum · 2025-10-26T00:59:25Z

Summary by CodeRabbit

Bug Fixes
- Fixed link rendering so style and class adjustments are correctly evaluated before being applied.
- Ensures link appearance and CSS classes display consistently across scenarios where previously styles or class names could be skipped.

coderabbitai · 2025-10-26T00:59:35Z

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

📥 Commits

Reviewing files that changed from the base of the PR and between 65a12de and e07055f.

📒 Files selected for processing (1)

packages/solid-router/src/link.tsx (1 hunks)

 _____________________________________________________
< The fifth dentist recommends we all floss our code. >
 -----------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       / 　 づ

Walkthrough

Modified the style spreading logic in the link component to correctly invoke the resolvedStyle accessor function by calling it with parentheses resolvedStyle() instead of referencing it as a value, ensuring proper retrieval of the computed style object.

Changes

Cohort / File(s)	Summary
Accessor function invocation fix `packages/solid-router/src/link.tsx`	Updated style property spreading to call `resolvedStyle()` instead of treating it as a non-function, aligning with its implementation as an accessor function

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Verify that resolvedStyle is indeed a Solid.js accessor/computed function that requires invocation
Confirm the fix is applied consistently to both the conditional check and the spread value
Check for similar patterns elsewhere in the file or related components that may need the same correction

Possibly related PRs

test(solid-router): un-skip link tests #5621: Addresses a similar accessor function invocation issue in the same file, calling externalLink() instead of referencing the function directly.

Suggested labels

package: solid-router

Poem

🐰 A function that once slept without a call,
Now wakes with () to serve us all!
In solid-router's link so true,
Accessors bloom when invoked anew. ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The PR title "fix(solid-router): apply style to link" directly corresponds to the main change in the changeset. The modification fixes how styles are applied to link elements by correcting a function invocation bug—specifically, changing `Object.keys(resolvedStyle).length` to `Object.keys(resolvedStyle()).length` so that the function is properly called before accessing its length. The title is concise, clear, and uses conventional commit formatting without vague terms or noise. It provides sufficient specificity to communicate to teammates that this is a style-related fix for the link component in solid-router.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2025-10-26T00:59:55Z

View your CI Pipeline Execution ↗ for commit e07055f

Command	Status	Duration	Result
`nx affected --targets=test:eslint,test:unit,tes...`	✅ Succeeded	6m 56s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	26s	View ↗

☁️ Nx Cloud last updated this comment at 2025-10-26 01:16:17 UTC

pkg-pr-new · 2025-10-26T01:01:42Z

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@5628

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@5628

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@5628

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@5628

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@5628

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@5628

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@5628

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@5628

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@5628

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@5628

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@5628

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@5628

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@5628

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@5628

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@5628

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@5628

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@5628

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@5628

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@5628

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@5628

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@5628

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@5628

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@5628

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-ssr-query@5628

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@5628

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@5628

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@5628

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@5628

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@5628

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@5628

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@5628

@tanstack/start-storage-context

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@5628

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@5628

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@5628

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@5628

commit: e07055f

* fix(solid-router): apply style to link * perf * ci: apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

fix(solid-router): apply style to link

65a12de

github-actions bot added the package: solid-router label Oct 26, 2025

birkskyum and others added 2 commits October 26, 2025 02:06

perf

cacba7f

ci: apply automated fixes

e07055f

birkskyum merged commit 4c3bd6b into main Oct 26, 2025
5 of 6 checks passed

birkskyum deleted the fix(solid-router)--apply-style-to-link branch October 26, 2025 01:28

birkskyum added this to the catch up solid to react milestone Oct 29, 2025

coderabbitai bot mentioned this pull request Nov 1, 2025

fix(solid-router): allow client-side-routing by link in SVG #5667

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(solid-router): apply style to link#5628

fix(solid-router): apply style to link#5628
birkskyum merged 3 commits intomainfrom
fix(solid-router)--apply-style-to-link

birkskyum commented Oct 26, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Oct 26, 2025 •

edited

Loading

Uh oh!

nx-cloud bot commented Oct 26, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Oct 26, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

birkskyum commented Oct 26, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Oct 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Poem

Pre-merge checks and finishing touches

Uh oh!

nx-cloud bot commented Oct 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Oct 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

birkskyum commented Oct 26, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Oct 26, 2025 •

edited

Loading

nx-cloud bot commented Oct 26, 2025 •

edited

Loading

pkg-pr-new bot commented Oct 26, 2025 •

edited

Loading