Conversation
WalkthroughRemoved 'react' from the optimizeDeps.include list in the Vite configuration for the react-start package. The entry 'react/jsx-runtime', 'react/jsx-dev-runtime', and 'react-dom' remain included for optimization, with only the main 'react' package excluded from forced optimization. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 0491dcd
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/arktype-adapter
@tanstack/directive-functions-plugin
@tanstack/eslint-plugin-router
@tanstack/history
@tanstack/nitro-v2-vite-plugin
@tanstack/react-router
@tanstack/react-router-devtools
@tanstack/react-router-ssr-query
@tanstack/react-start
@tanstack/react-start-client
@tanstack/react-start-server
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-devtools-core
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-ssr-query-core
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/solid-router-devtools
@tanstack/solid-start
@tanstack/solid-start-client
@tanstack/solid-start-server
@tanstack/start-client-core
@tanstack/start-plugin-core
@tanstack/start-server-core
@tanstack/start-static-server-functions
@tanstack/start-storage-context
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
Currently tests using vitest fail to run giving an error of:
TypeError: Cannot read properties of null (reading 'useState')Recreated in this example
What's more revealing is the "rules of hooks" warnings above the test, which could indicate something being loaded twice:
These errors go away if the TanStack start plugin is removed from
vite.config.jsas mentioned here:https://discord.com/channels/719702312431386674/1425117017140367421
I am no Vite plugin expert, but by simply removing the second
reactinclude line this issue was resolved for me. There may be a more elegant or correct solution than this, but hopefully this at least helps. I would have thought thededupelines above would've done the same task, so maybe this is not a bug here and could be a Vite issue instead 🤔Summary by CodeRabbit