fix(router-core): change error type in ErrorComponentProps by leesb971204 · Pull Request #4691 · TanStack/router

leesb971204 · 2025-07-17T22:56:52Z

Signed-off-by: leesb971204 <leesb971204@gmail.com>

nx-cloud · 2025-07-17T22:57:17Z

View your CI Pipeline Execution ↗ for commit 21d3dff

Command	Status	Duration	Result
`nx affected --targets=test:eslint,test:unit,tes...`	✅ Succeeded	6m 9s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	2m 6s	View ↗

☁️ Nx Cloud last updated this comment at 2025-07-20 02:32:35 UTC

packages/router-core/src/route.ts

Signed-off-by: leesb971204 <leesb971204@gmail.com>

pkg-pr-new · 2025-07-17T23:33:02Z

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@4691

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@4691

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@4691

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@4691

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@4691

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@4691

@tanstack/react-router-with-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-with-query@4691

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@4691

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@4691

@tanstack/react-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-plugin@4691

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@4691

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@4691

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@4691

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@4691

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@4691

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@4691

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@4691

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@4691

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@4691

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@4691

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@4691

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@4691

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@4691

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@4691

@tanstack/solid-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-plugin@4691

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@4691

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@4691

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@4691

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@4691

@tanstack/start-server-functions-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-client@4691

@tanstack/start-server-functions-fetcher

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-fetcher@4691

@tanstack/start-server-functions-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-server@4691

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@4691

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@4691

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@4691

commit: 21d3dff

…r type Signed-off-by: leesb971204 <leesb971204@gmail.com>

leesb971204 · 2025-07-19T12:54:17Z

packages/router-core/src/route.ts

-export type ErrorComponentProps = {
-  error: Error
+export type ErrorComponentProps<TError = Error> = {
+  error: TError


This reflects @michaelbull ’s suggestion.

The change respects the diversity of error objects returned from the backend while setting Error as the default type to ensure compatibility with existing code.

schiller-manuel · 2025-07-19T22:52:02Z

thanks for this PR!

can you please update the docs

docs/router/framework/react/api/router/errorComponentComponent.md

Signed-off-by: leesb971204 <leesb971204@gmail.com>

leesb971204 · 2025-07-20T02:27:01Z

thanks for this PR!

can you please update the docs

docs/router/framework/react/api/router/errorComponentComponent.md

I updated the type of the error, and also added a description for info, which seemed to be missing.

…4691) fixes TanStack#4686 --------- Signed-off-by: leesb971204 <leesb971204@gmail.com>

fix(router-core): change error type to unknown in ErrorComponentProps

7f3b3a9

Signed-off-by: leesb971204 <leesb971204@gmail.com>

github-actions bot added the package: router-core label Jul 17, 2025

leesb971204 commented Jul 17, 2025

View reviewed changes

packages/router-core/src/route.ts Outdated Show resolved Hide resolved

fix: remove explicit error type in errorComponent for CatchNotFound

7bccf2e

Signed-off-by: leesb971204 <leesb971204@gmail.com>

github-actions bot added package: react-router package: solid-router labels Jul 17, 2025

leesb971204 added 2 commits July 19, 2025 19:57

Merge branch 'main' into fix/error-component-props-type

00d812a

fix(router-core): update ErrorComponentProps type to use generic erro…

cc66bfd

…r type Signed-off-by: leesb971204 <leesb971204@gmail.com>

leesb971204 force-pushed the fix/error-component-props-type branch from 21713c1 to cc66bfd Compare July 19, 2025 12:25

leesb971204 commented Jul 19, 2025

View reviewed changes

docs(router-core): update errorComponentComponent.md

21d3dff

Signed-off-by: leesb971204 <leesb971204@gmail.com>

github-actions bot added the documentation Everything documentation related label Jul 20, 2025

schiller-manuel merged commit e63f4e4 into TanStack:main Jul 20, 2025
5 checks passed

leesb971204 mentioned this pull request Jul 21, 2025

fix(router-core): update ErrorComponentProps to not support generic error type #4727

Open

naoya7076 pushed a commit to naoya7076/router that referenced this pull request Feb 15, 2026

fix(router-core): change error type in ErrorComponentProps (TanStack#…

d7669e9

…4691) fixes TanStack#4686 --------- Signed-off-by: leesb971204 <leesb971204@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(router-core): change error type in ErrorComponentProps#4691

fix(router-core): change error type in ErrorComponentProps#4691
schiller-manuel merged 5 commits intoTanStack:mainfrom
leesb971204:fix/error-component-props-type

leesb971204 commented Jul 17, 2025 •

edited

Loading

Uh oh!

nx-cloud bot commented Jul 17, 2025 •

edited

Loading

Uh oh!

Uh oh!

pkg-pr-new bot commented Jul 17, 2025 •

edited

Loading

Uh oh!

leesb971204 Jul 19, 2025

Uh oh!

schiller-manuel commented Jul 19, 2025

Uh oh!

leesb971204 commented Jul 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

leesb971204 commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nx-cloud bot commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

pkg-pr-new bot commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

leesb971204 Jul 19, 2025

Choose a reason for hiding this comment

Uh oh!

schiller-manuel commented Jul 19, 2025

Uh oh!

leesb971204 commented Jul 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

leesb971204 commented Jul 17, 2025 •

edited

Loading

nx-cloud bot commented Jul 17, 2025 •

edited

Loading

pkg-pr-new bot commented Jul 17, 2025 •

edited

Loading