fix(query-core): set options before checking experimental_prefetchInR…#9412
Closed
fix(query-core): set options before checking experimental_prefetchInR…#9412
Conversation
|
View your CI Pipeline Execution ↗ for commit 9a4c3a9
☁️ Nx Cloud last updated this comment at |
Contributor
|
Sizes for commit 9a4c3a9:
|
Member
Author
|
The issue appear to be that the client isn't passed to the QueryObserver constructor for solid-query |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9412 +/- ##
===========================================
+ Coverage 45.39% 59.70% +14.31%
===========================================
Files 208 137 -71
Lines 8279 5517 -2762
Branches 1865 1477 -388
===========================================
- Hits 3758 3294 -464
+ Misses 4080 1925 -2155
+ Partials 441 298 -143 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR
I'm facing the error, in the /e2e/solid-start/basic-solid-query project in the Posts and Users pages:
Cannot read properties of undefined (reading 'experimental_prefetchInRender')I believe it's because it's checking the property on the options object before setting the options object on the next line.
This swaps that around